Upstream merge #65
Merged
Upstream merge #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* JI-5522 disably activityheader for embed in moodle4.0+ * JI-5522 fix resizing for embedded h5ps
…ble to turn off (h5p#555) * JI-5044 Turn Content Hub on by default * JI-5044 Update fallback value for getOption * JI-5044 Add missing translations * JI-5044 Update translations --------- Co-authored-by: Lars-Magnus Underhaug <lars-magnus.underhaug@joubel.com>
Resolves 4.5 compatibility - install failure h5p#562 Replaced MESSAGE_DEFAULT_LOGGEDIN + MESSAGE_DEFAULT_LOGGEDOFF to MESSAGE_DEFAULT_ENABLED as per Moodle plugin upgrade documentation: https://github.com/moodle/moodle/blob/13c12756b4d7e85f2d2e34038216179fd287c9c2/lib/upgrade.txt#L716 Thanks @otacke and @lkcivan
Update messages.php resolves h5p#562
|
CI is failing because of phpcs, but checked and the unit tests are good. The changes also seem somewhat trivial so no concerns there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.