Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: totara compatibility #69

Merged
merged 1 commit into from
Feb 18, 2025
Merged

feat: totara compatibility #69

merged 1 commit into from
Feb 18, 2025

Conversation

matthewhilton
Copy link

Changes

  • Adds some defined checks around constants that changed in 4.1 / 4.5 that Totara doesn't have.

Notes

  • These changes are small enough that they should just be in the stable-catalyst branch, as opposed to making a whole new totara specific branch

@rhell4
Copy link

rhell4 commented Feb 18, 2025

Looks good to me, I agree that these are so minor it's not worth creating another branch. It would be nice to get unit tests passing but I see they've always been failing and that might be a bigger task on its own.

@rhell4 rhell4 merged commit edd9c82 into stable-catalyst Feb 18, 2025
7 of 28 checks passed
@rhell4 rhell4 deleted the totara-compatibility branch February 18, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants