Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #134: remove completionpassgrade from settings #135

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

rhell4
Copy link
Contributor

@rhell4 rhell4 commented Jun 25, 2024

There is no grade to pass setting for observations so the completionpassgrade option is not needed and presents an error if the user tries to turn it on and save the activity.

@Peterburnett
Copy link
Collaborator

This one looks good to go, nice and simple change, however there is a CI fail that would be nice to resolve before we merge it in

@rhell4 rhell4 force-pushed the issue134-passing-grade-completion branch from 3cd2116 to 6a16985 Compare June 26, 2024 00:54
@Peterburnett Peterburnett merged commit 10c15bc into MOODLE_400_STABLE Jun 26, 2024
8 checks passed
@Peterburnett Peterburnett deleted the issue134-passing-grade-completion branch June 26, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants