Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#140] properly save and load html instructions #141

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

matthewhilton
Copy link
Collaborator

@matthewhilton matthewhilton commented Feb 25, 2025

Closes #140

Changes

Other misc updates:

  • Fix version.php so the ci actually runs - wasn't actually running anything at all before 🙈
  • Fix up about a zillion codechecker and phpdoc issues

Testing
Tested this manually saving and loading observation point html, now correctly saves the html tags and displays it properly

Copy link
Contributor

@keevan keevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, and thanks for cleaning up the existing code.

@keevan keevan merged commit 77d32b6 into MOODLE_400_STABLE Feb 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML in observation point instructions not saved
2 participants