issue #116: improve UX #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitriim
force-pushed
the
issue116
branch
2 times, most recently
from
749d9be to
84b154b
Compare
dmitriim
commented
Feb 23, 2025
| @@ -48,16 +48,17 @@ protected function initialise(): void { | |||
| $this->add_entity($userentity); | |||
|
|
|||
| $conditions = $rule->get_condition_records(); | |||
| $sql = condition_manager::build_sql_data($conditions, $rule->get('operator')); | |||
There was a problem hiding this comment.
Changes in this file are related to an error that was displayed when a rule doesn't have any conditions. Found that while working on new UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New UI is implemented as part of this PR. All manipulations with rules and conditions now happen without page refresh.
All operations like delete or toggle rules moved to web services. Rules form has been converted to dynamic form. Matching users are now displayed in pop-up modal.