Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #116: improve UX #119

Merged
merged 6 commits into from
Feb 27, 2025
Merged

issue #116: improve UX #119

merged 6 commits into from
Feb 27, 2025

Conversation

dmitriim
Copy link
Member

@dmitriim dmitriim commented Nov 23, 2024

New UI is implemented as part of this PR. All manipulations with rules and conditions now happen without page refresh.

All operations like delete or toggle rules moved to web services. Rules form has been converted to dynamic form. Matching users are now displayed in pop-up modal.

image

image

@dmitriim dmitriim force-pushed the issue116 branch 2 times, most recently from 749d9be to 84b154b Compare February 21, 2025 13:02
@dmitriim dmitriim marked this pull request as ready for review February 21, 2025 13:08
@@ -48,16 +48,17 @@ protected function initialise(): void {
$this->add_entity($userentity);

$conditions = $rule->get_condition_records();
$sql = condition_manager::build_sql_data($conditions, $rule->get('operator'));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file are related to an error that was displayed when a rule doesn't have any conditions. Found that while working on new UI.

@dmitriim dmitriim merged commit fc7918b into MOODLE_404_STABLE Feb 27, 2025
15 checks passed
@dmitriim dmitriim deleted the issue116 branch March 2, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant