Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #68: Moodle 4.4 support #95

Merged
merged 2 commits into from
Jun 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -8,9 +8,11 @@ Dynamic cohorts plugin allows dynamically add and remove users from cohorts base

# Versions and branches

| Moodle Version | Branch |
|----------------|-------------------|
| Moodle 4.1+ | MOODLE_401_STABLE |
| Moodle Version | Branch |
|------------------|-------------------|
| Moodle 4.1 - 4.3 | MOODLE_401_STABLE |
| Moodle 4.4+ | MOODLE_404_STABLE |


## Installing via uploaded ZIP file ##

4 changes: 2 additions & 2 deletions classes/reportbuilder/local/entities/rule_entity.php
Original file line number Diff line number Diff line change
@@ -34,9 +34,9 @@ class rule_entity extends base {
* Returns the default table aliases.
* @return array
*/
protected function get_default_table_aliases(): array {
protected function get_default_tables(): array {
return [
'tool_dynamic_cohorts' => 'tdc',
'tool_dynamic_cohorts',
];
}

Original file line number Diff line number Diff line change
@@ -42,6 +42,7 @@ protected function initialise(): void {
$rule = rule::get_record(['id' => $ruleid], MUST_EXIST);

$userentity = new user();
$userentity->set_table_alias('user', 'u');
$usertablealias = $userentity->get_table_alias('user');
$this->set_main_table('user', $usertablealias);
$this->add_entity($userentity);
6 changes: 3 additions & 3 deletions version.php
Original file line number Diff line number Diff line change
@@ -25,8 +25,8 @@
defined('MOODLE_INTERNAL') || die();

$plugin->component = 'tool_dynamic_cohorts';
$plugin->release = 2024051000;
$plugin->version = 2024051000;
$plugin->release = 2024062200;
$plugin->version = 2024062200;
$plugin->requires = 2022112800;
$plugin->supported = [401, 403];
$plugin->supported = [404, 404];
$plugin->maturity = MATURITY_STABLE;