Fix checking SASLHandshake from APIVersions #4983
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
librdkafka
's current (SASL) authentication behavior:It sends an
APIVersions
request and setsRD_KAFKA_FEATURE_SASL_HANDSHAKE
if the supported versions ofSASLHandshake
from server overlap with[0, 0]
.If not set, it errors with SASL Handshake not supported by broker.
If set, it sends a
SASLHandshake
request at the supported highest version in[0, 1]
.In short, if the server doesn't support version 0,
librdkafka
errors. If the server supports version 0 and 1,librdkafka
sends a request at version 1.This PR fixes step 1 to make it allow versions
[0, 1]
, consistent with step 3.