Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking SASLHandshake from APIVersions #4983

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oliversun9
Copy link

librdkafka's current (SASL) authentication behavior:

  1. It sends an APIVersions request and sets RD_KAFKA_FEATURE_SASL_HANDSHAKE if the supported versions of SASLHandshake from server overlap with [0, 0].

  2. If not set, it errors with SASL Handshake not supported by broker.

  3. If set, it sends a SASLHandshake request at the supported highest version in [0, 1].

In short, if the server doesn't support version 0, librdkafka errors. If the server supports version 0 and 1, librdkafka sends a request at version 1.

This PR fixes step 1 to make it allow versions [0, 1], consistent with step 3.

@oliversun9 oliversun9 requested a review from a team as a code owner March 6, 2025 03:22
@confluent-cla-assistant
Copy link

confluent-cla-assistant bot commented Mar 6, 2025

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ oliversun9
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant