[v5.4-rhel] Create quota before _data dir for volumes #25488
Conversation
openshift-ci
bot
added
release-note-none
approved
mheon
changed the title
|
@TomSweeneyRedHat PTAL |
This resolves an ordering issue that prevented quotas from being applied. XFS quotas are applied recursively, but only for subdirectories created after the quota is applied; if we create `_data` before the quota, and then use `_data` for all data in the volume, the quota will never be used by the volume. Also, add a test that volume quotas are working as designed using an XFS formatted loop device in the system tests. This should prevent any further regressions on basic quota functionality, such as quotas being shared between volumes. Fixes containers#25368 Fixes https://issues.redhat.com/browse/RHEL-82198 Fixes https://issues.redhat.com/browse/RHEL-82199 Signed-off-by: Matt Heon <[email protected]>
mheon
force-pushed
the
backport_25368_fix
branch
from
6a9ed71 to
a28e9fa
Compare
There was a problem hiding this comment.
LGTM, but I like to have ack from @TomSweeneyRedHat
Also I suppose we should backport this in the regular 5.4 branch as well for next release.
|
/cherry-pick v5.4 From here, not the original, so we don't get the storage bump |
|
@mheon: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I'm just going to go ahead and merge given this is a cherry-pick. |
|
@mheon: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Damn, I didn't use the cherry-pick bot for this, so I can't cheat the merge. Hah. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, lsm5, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e48006b
into
containers:v5.4-rhel
|
@mheon: new pull request created: #25515 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Backport of #25417 minus the c/storage update to v5.4-rhel branch.
Fixes https://issues.redhat.com/browse/RHEL-82198
Fixes https://issues.redhat.com/browse/RHEL-82199
Does this PR introduce a user-facing change?