Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve ProtocolClient initialization and GUI loading #4759

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lkk214
Copy link
Contributor

@lkk214 lkk214 commented Mar 21, 2025

Description

  • ContinueBrowser adds LoadHandler before loading the GUI
  • Load the url after protocolClient is initialized

Some messages will be lost if the "Continue" tool window is open during JetBrains IDE startup, as this can cause the GUI to initialize without data.

Affected message types: jetbrains/isOSREnabled, jetbrains/getColors, jetbrains/onLoad, etc.

Currently, it is obvious that you can't right-click and "Open Dev Tools", and the theme color of the GUI is unexpected. These issues occur specifically when the "Continue" tool window is open during JetBrains IDE startup.

- Introduce `onProtocolClientInitialized` to handle client initialization events.
- Use `Delegates.observable` for `ideProtocolClient` to trigger listeners on changes.
- Ensure URL loading is deferred until protocol client is initialized.
@lkk214 lkk214 requested a review from a team as a code owner March 21, 2025 18:54
@lkk214 lkk214 requested review from sestinj and removed request for a team March 21, 2025 18:54
Copy link

netlify bot commented Mar 21, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 0c829fd
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67ddb5f4ad5dcc0009ec6d1a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant