Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(volume-viewport): call render for the scroll to take effect #1899

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

minimal-scouser
Copy link
Contributor

Context

calling scroll on a volume viewport does not actually scroll the viewport. it sets camera properties (focal point and position) but it needs a render to get those committed to viewport.

Changes & Results

call render method inside the scroll method of baseVolumeViewport

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit c2e746d
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/67d2f560d4798e0008cdd2fe
😎 Deploy Preview https://deploy-preview-1899--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants