Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes loading error when using wado-uri to load a volume #1902

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmhmd
Copy link
Contributor

@jmhmd jmhmd commented Mar 14, 2025

Context

In the case of loading a new volume with WADO-URI, we may not have loaded
metadata for all imageIds, as they are streaming in. The
getViewReference() call uses getClosestImageId() in its call stack, which
will error in that scenario as it tries to loop over all imageId
metadata. So only call getViewReference if necessary.

Changes & Results

Removes unnecessary function call that errors in specific scenarios.

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 9fc3aea
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/67d385074d4303000816f3ce
😎 Deploy Preview https://deploy-preview-1902--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant