Fix __libc_fatal('*** invalid %N$ use detected ***') #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to my misunderstanding of _exactly_ how to use `printf()`'s [parameter field](https://en.wikipedia.org/wiki/Printf_format_string#Parameter_field), then under some PGTBOX(...) settings and with certain time axis range, the 'sprintf(...)' would trigger an `__libc_fatal(...)` - terminating the user's application. The fatal error was only triggered if DAY number was to be displayed and DAY number was non-negative. By a simple permutation of the calling arguments and the parameter field(s) in the format strings this should not happen anymore.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to my misunderstanding of exactly how to use
printf()'s parameterfield,
then under some PGTBOX(...) settings and with certain time axis range, the
'sprintf(...)' would trigger a
__libc_fatal(...)- terminating the user'sapplication.
The fatal error was only triggered if DAY number was to be displayed and DAY
number was non-negative.
By a simple permutation of the calling arguments and the parameter field(s)
in the format strings this should not happen anymore.