Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adaptive): fixed comparison in recommendations when scaling down #8273

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Vesyrak
Copy link

@Vesyrak Vesyrak commented Oct 13, 2023

Closes #8119

I never got any real response, but we do encounter this issue, so this is a proposed fix.
If this can cause any unwanted behaviour, please let me know. Did not override observed since I'm not entirely sure how far this would impact the codebase.

  • [ 0 / ? ] Tests added / passed

    • I get a timeout on test_blocks_until_full, with a side dish of Too many open files
  • [ x ] Passes pre-commit run --all-files

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ± 0      27 suites  ±0   10h 42m 36s ⏱️ + 48m 44s
 3 995 tests ± 0   3 874 ✅  -   9    110 💤 ±0   11 ❌ +  9 
50 241 runs  +18  47 817 ✅  - 105  2 293 💤  - 6  131 ❌ +129 

For more details on these failures, see this check.

Results for commit a5cc593. ± Comparison against base commit 1211e79.

♻️ This comment has been updated with latest results.

@Vesyrak Vesyrak force-pushed the fix/adaptive-recommendations branch 2 times, most recently from a612efc to 7034a1b Compare October 18, 2023 17:58
@Vesyrak Vesyrak force-pushed the fix/adaptive-recommendations branch from 7034a1b to 92ea89e Compare February 13, 2024 14:25
@Vesyrak Vesyrak force-pushed the fix/adaptive-recommendations branch from 92ea89e to 49f3722 Compare February 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommendation Requested / Observed mismatch
3 participants