refactor(spec): reduce complexity new_worker_spec #8428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? Admins can comment |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 26 files - 1 26 suites - 1 1h 0m 45s ⏱️ -16s For more details on these failures and errors, see this check. Results for commit ea9bcbd. ± Comparison against base commit c98cd09. ♻️ This comment has been updated with latest results. |
Vesyrak
force-pushed
the
refactor/worker_spec
branch
from
19d950d to
ea9bcbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces accidental complexity regarding worker spec naming.
I'm not sure why the last worker name was re-used, but not re-using it makes it easier to keep internal states consistent and increases code readability.
[ ] Tests added / passedI get to 4% of tests in 25 minutes locally, so that doesn't work. All CI pipelines succeeded apart from one for MacOS, which failed in an unrelated test.
[ ] Passespre-commit run --all-filespre-commit failed for me on the master branch itself.