Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MambaInstall plugin #8515

Closed
wants to merge 1 commit into from

Conversation

wietzesuijker
Copy link

Enables the use of both Mamba and Micromamba for package installation, offering flexibility depending on user preference or environment constraints.
Mamba accelerates package installation and dependency resolution compared to Conda.

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@wietzesuijker wietzesuijker force-pushed the feat/MambaInstall branch 3 times, most recently from 02854ea to fe96c0b Compare February 20, 2024 15:29
feat: MambaInstall plugin

feat: MambaInstall plugin

feat: MambaInstall plugin

feat: MambaInstall plugin
@wietzesuijker
Copy link
Author

ok to test from my perspective. Nit: sorry I initially missed the section on code formatting

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ± 0      27 suites  ±0   10h 0m 35s ⏱️ - 9m 3s
 3 994 tests ± 0   3 884 ✅ + 1    109 💤 ±0  1 ❌  - 1 
50 230 runs  +18  47 939 ✅ +26  2 290 💤  - 6  1 ❌  - 2 

For more details on these failures, see this check.

Results for commit 40e5c88. ± Comparison against base commit b03efee.

@wietzesuijker
Copy link
Author

Just realised that the channels arg could be squashed into the options. However, I'd rather have it explicit (if we go ahead with that, this would also need a small change in the CondaInstall class)

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to raise this.

Given that libmamba is now the default conda solver it sort of feels like mamba will gradually disappear. Especially given the mamba devs are now focused on pixi.

What benefit does this plugin give over the existing CondaInstall with modern versions of conda?

@wietzesuijker
Copy link
Author

Thanks I didn't fully appreciate those changes. I quickly tested CondaInstall and MambaInstall, and they perform quite similarly indeed! The only use case would be for setups that do have (micro)mamba, but not conda installed. Fine to close though!

@wietzesuijker wietzesuijker deleted the feat/MambaInstall branch June 4, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants