Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows ci to avoid os.getuid #8989

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Jan 16, 2025

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

@phofl phofl requested a review from fjetter as a code owner January 16, 2025 15:03
@phofl phofl changed the title Fix windows ci for skipif Fix windows ci to avoid os.getuid Jan 16, 2025
@jacobtomlinson
Copy link
Member

jacobtomlinson commented Jan 16, 2025

Looks like this fixes a break introduced by #8987. Thanks @phofl. cc @TomAugspurger for visibility

@jacobtomlinson jacobtomlinson merged commit 15e518a into dask:main Jan 16, 2025
26 of 31 checks passed
@phofl phofl deleted the windows_ci branch January 16, 2025 15:57
@TomAugspurger
Copy link
Member

Whoops, sorry about that and thanks for fixing it!

@jacobtomlinson
Copy link
Member

It's ok, I somehow totally missed it in review too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants