Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Clean tuples dict keys from workers_info in /api/v1/retire_workers. #8996

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion distributed/http/scheduler/api.py
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@
import json

from distributed.http.utils import RequestHandler
from distributed.utils import recursive_to_dict


class APIHandler(RequestHandler):
@@ -24,7 +25,7 @@ async def post(self):
else:
workers = params.get("workers", {})
workers_info = await scheduler.retire_workers(workers=workers)
self.write(json.dumps(workers_info))
self.write(json.dumps(recursive_to_dict(workers_info)))
except Exception as e:
self.set_status(500, str(e))
self.write(json.dumps({"Error": "Internal Server Error"}))
47 changes: 47 additions & 0 deletions distributed/http/scheduler/tests/test_scheduler_http.py
Original file line number Diff line number Diff line change
@@ -720,6 +720,53 @@ async def test_retire_workers(c, s, a, b):
assert len(retired_workers_info) == 2


@gen_cluster(
client=True,
clean_kwargs={"threads": False},
config={
"distributed.scheduler.http.routes": DEFAULT_ROUTES
+ ["distributed.http.scheduler.api"]
},
)
async def test_retire_workers_with_tuple_keys(c, s, a, b):
aiohttp = pytest.importorskip("aiohttp")

worker_address = "tcp://172.17.0.3:39571"

async def mock_retire_workers(*args, **kwargs):
# Return problematic data structure
# tuple are not json serializable
return {
worker_address: {
"type": "Worker",
"metrics": {
"digests_total_since_heartbeat": {
(
"execute",
"slowadd",
"thread-cpu",
"seconds",
): 0.0003396660000000093,
},
},
}
}

# Replace the method with our mock
s.retire_workers = mock_retire_workers

async with aiohttp.ClientSession() as session:
params = {"workers": [a.address, b.address]}
async with session.post(
"http://localhost:%d/api/v1/retire_workers" % s.http_server.port,
json=params,
) as resp:
assert resp.status == 200
assert resp.headers["Content-Type"] == "application/json"
retired_workers_info = json.loads(await resp.text())
assert worker_address in retired_workers_info


@gen_cluster(
client=True,
clean_kwargs={"threads": False},