Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove traceback from sizeof failure warning #9006

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

jacobtomlinson
Copy link
Member

Closes #8566

Logging the traceback from a sizeof failure seems like it doesn't add much value to users. It might be helpful when debugging why it's happening.

This PR removes the traceback from the warning but adds a debug log which includes the traceback. This allows folks to see it when they want to by setting the appropriate log level.

  • Tests added / passed
  • Passes pre-commit run --all-files

Sorry, something went wrong.

@jacobtomlinson jacobtomlinson changed the title Remove traceback from sizeof failure Remove traceback from sizeof failure warning Feb 11, 2025
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±0      27 suites  ±0   11h 47m 22s ⏱️ + 13m 15s
 4 120 tests ±0   4 000 ✅  - 9    111 💤 ±0  8 ❌ +8  1 🔥 +1 
51 668 runs  +1  49 362 ✅  - 8  2 297 💤 ±0  8 ❌ +8  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 8b5874e. ± Comparison against base commit 55bb639.

Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I assume you ran into this yourself? sizeof warnings are not critical but if the estimation is wrong this can cause uncomfortable scheduling artifacts so I recommend looking into it. I agree that we don't need to spam the logs because of this.

@fjetter fjetter merged commit 06be061 into dask:main Feb 13, 2025
27 of 34 checks passed
@jacobtomlinson jacobtomlinson deleted the quiet-sizeof-default branch February 14, 2025 11:09
@jacobtomlinson
Copy link
Member Author

jacobtomlinson commented Feb 14, 2025

No I didn't run into this. I was just triaging issues and this one seemed like a quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sizeof traceback is very long
2 participants