Hotfix: Ignore negative occupancy #9012
Conversation
| self._network_occ -= nbytes | ||
| self.scheduler._network_occ_global -= nbytes | ||
| # FIXME: ts.get_nbytes may change if non-deterministic tasks get recomputed, causing drift | ||
| self._network_occ -= min(nbytes, self._network_occ) |
There was a problem hiding this comment.
is network_occ an integer or are we dealing with floating point foo at this point?
There was a problem hiding this comment.
looks like _network_occ_global is defined as a float. I guess this won't be a drama since we only add and subtract integers.
There was a problem hiding this comment.
I've adjusted types and initial values to match the assumption of integer values.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 11h 19m 21s ⏱️ - 3m 43s For more details on these failures, see this check. Results for commit b121e39. ± Comparison against base commit 33b229a. |
This PR adds a hotfix that handles drift in occupancy leading to negative values.
pre-commit run --all-files