-
-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI by using client.persist(collection)
instead of collection.persist()
#9020
Conversation
Am I right in understaning that this is because |
Yes, this raises by default. There is a fallback option but that also warns, so I opted for the explicit usage of the async client. |
@@ -3407,68 +3407,6 @@ def test_default_get(loop_in_thread): | |||
assert dask.base.get_scheduler() == pre_get | |||
|
|||
|
|||
@gen_cluster(config={"scheduler": "sync"}, nthreads=[]) | |||
async def test_get_scheduler_default_client_config_interleaving(s): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_scheduler()
never returns an async client now, so this test has become obsolete.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ± 0 27 suites ±0 11h 37m 34s ⏱️ + 15m 0s For more details on these failures, see this check. Results for commit 755b9ea. ± Comparison against base commit ad6f7d9. This pull request removes 1 test.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks for resolving this @hendrikmakait.
CI failures appear unrelated.
CI has been pretty broken ever since we merged dask/dask#11790.
This PR fixes that.
pre-commit run --all-files