Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpecCluster: add option to *not* shut down the scheduler when the cluster is closed #9021

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

nocnokneo
Copy link
Contributor

Add shutdown_scheduler option to SpecCluster. Defaults to True so this is backward compatible.

Copy link
Contributor

github-actions bot commented Mar 11, 2025

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ± 0      27 suites  ±0   11h 43m 41s ⏱️ + 13m 48s
 4 102 tests + 2   3 989 ✅ + 6    111 💤 ±0  2 ❌  - 4 
51 430 runs  +26  49 131 ✅ +29  2 297 💤 +1  2 ❌  - 4 

For more details on these failures, see this check.

Results for commit fa66395. ± Comparison against base commit 7df4356.

♻️ This comment has been updated with latest results.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think we will need to go through the various implementations of SpecCluster and set this value in cases where we also set shutdown_on_close=False.

@jacobtomlinson
Copy link
Member

Merged in from main to resolve CI issues

@jacobtomlinson jacobtomlinson merged commit a2a5aee into dask:main Mar 12, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants