Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure FileInfo can be serialized #9025

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Ensure FileInfo can be serialized #9025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions distributed/protocol/arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,14 @@ def deserialize_table(header, frames):
blob = frames[0]
reader = pyarrow.RecordBatchStreamReader(pyarrow.BufferReader(blob))
return reader.read_all()


@dask_serialize.register(pyarrow.fs.FileInfo)
def serialize_fileinfo(fileinfo):
return {}, [(fileinfo.path, fileinfo.size, fileinfo.mtime_ns)]


@dask_deserialize.register(pyarrow.fs.FileInfo)
def serialize_filesystem(header, frames):
path, size, mtime_ns = frames[0]
return pyarrow.fs.FileInfo(path=path, size=size, mtime_ns=mtime_ns)
12 changes: 12 additions & 0 deletions distributed/protocol/tests/test_arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,15 @@ def test_dumps_compression():
msg = {"op": "update", "data": to_serialize(t)}
result = distributed.protocol.loads(distributed.protocol.dumps(msg))
assert result["data"].equals(t)


def test_dump_fileinfo():
from pyarrow.fs import FileInfo

finfo = FileInfo(path="path", size=1, mtime_ns=2)
dtfinfo = deserialize(*serialize(finfo))
# Does not implement __equal__
assert type(dtfinfo) == FileInfo
assert dtfinfo.path == finfo.path
assert dtfinfo.size == finfo.size
assert dtfinfo.mtime_ns == finfo.mtime_ns
Loading