Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly forward cancellation reason #9028

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Mar 18, 2025

This will attach a reason to the exception if we know the cause. The causes spelled out here are still rather ambiguous but it's a little better than just "unknown"

Copy link
Contributor

github-actions bot commented Mar 18, 2025

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±0      27 suites  ±0   11h 49m 14s ⏱️ + 10m 57s
 4 103 tests ±0   3 988 ✅  - 2    111 💤 ±0  4 ❌ +2 
51 441 runs  ±0  49 140 ✅  - 2  2 297 💤 ±0  4 ❌ +2 

For more details on these failures, see this check.

Results for commit 2bd2c0e. ± Comparison against base commit e931ccd.

♻️ This comment has been updated with latest results.

@fjetter fjetter force-pushed the properly_forward_cancellation_reason branch from 3115706 to 2bd2c0e Compare March 18, 2025 16:54
@fjetter fjetter merged commit ce90c4a into dask:main Mar 19, 2025
27 of 31 checks passed
@fjetter fjetter deleted the properly_forward_cancellation_reason branch March 19, 2025 10:01
@fcourtial
Copy link

@fjetter Could we release a version with this fix?

I was about to contribute the same kind of fix, when we cancel a Future on purpose, for instance because the user wants to stop the running job, then a FutureCancelledException is triggered with the reason unknown whereas we did provide a reason when cancelling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants