Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui) Fix group membership inconsistencies on group page #12704

Conversation

chriscollins3456
Copy link
Collaborator

There were several inconsistencies on the group page regarding the number of members in a group.

  1. On the top left of the page we showed a max count of 15 since we were dislaying the number of members we retrieved from our call, not the total number of members
  2. Same thing on the left sidebar, it was wonky and made you think you only had 15. now, if there's more, i display a new link to "View all members" that takes you to the members tab to do a look at all the members of the group.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Feb 21, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 41.02564% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...tityV2/group/GroupMembersSidebarSectionContent.tsx 31.81% 15 Missing ⚠️
...ared/containers/profile/sidebar/SidebarSection.tsx 57.14% 3 Missing ⚠️
.../src/app/entityV2/group/GroupInfoHeaderSection.tsx 0.00% 2 Missing ⚠️
.../app/entityV2/group/GroupSidebarMembersSection.tsx 0.00% 2 Missing ⚠️
...-web-react/src/app/entityV2/group/GroupProfile.tsx 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (41.02%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
datahub-web-react/src/app/entityV2/group/types.ts 100.00% <100.00%> (ø)
...-web-react/src/app/entityV2/group/GroupProfile.tsx 35.45% <50.00%> (-1.16%) ⬇️
.../src/app/entityV2/group/GroupInfoHeaderSection.tsx 64.51% <0.00%> (ø)
.../app/entityV2/group/GroupSidebarMembersSection.tsx 52.63% <0.00%> (+2.63%) ⬆️
...ared/containers/profile/sidebar/SidebarSection.tsx 97.60% <57.14%> (-2.41%) ⬇️
...tityV2/group/GroupMembersSidebarSectionContent.tsx 30.76% <31.81%> (-0.94%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b4acf0...06d16a3. Read the comment docs.

@chriscollins3456 chriscollins3456 merged commit 6a8254c into datahub-project:master Feb 26, 2025
154 of 185 checks passed
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants