Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui) Fix changing color and icon for domains in UI #12792

Conversation

chriscollins3456
Copy link
Collaborator

There were a few bugs related to changing the color and icon for a domain that are fixed in this PR:

  • add the aspect to the entity registry (added it for glossary nodes too as they were missing)
  • fetch this aspect when loading a domain
  • query for this aspect from the UI
  • fix weird debounce behavior in UI where we save changing the icon and color before we click "save" in the modal.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ners/profile/header/IconPicker/IconColorPicker.tsx 0.00% 3 Missing ⚠️
datahub-web-react/src/app/domain/DomainsList.tsx 0.00% 1 Missing ⚠️
datahub-web-react/src/app/domain/utils.ts 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chriscollins3456 chriscollins3456 merged commit 1068e2b into datahub-project:master Mar 5, 2025
86 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants