fix: search cache invalidation for iceberg entities #12805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
chakru-r
changed the title
chakru-r
force-pushed
the
iceberg-cache-invalidation
branch
from
5b8dcc3 to
8a9e06e
Compare
chakru-r
force-pushed
the
iceberg-cache-invalidation
branch
from
8a9e06e to
60bcda1
Compare
chakru-r
force-pushed
the
iceberg-cache-invalidation
branch
from
60bcda1 to
615dfc0
Compare
datahub-cyborg
bot
added
the
needs-review
| } | ||
|
|
||
| private Set<Object> getKeys(String cacheName) { | ||
| // Enumerating cache keys is not part of the standard Cache interface, but needs is native cache |
There was a problem hiding this comment.
This is unfortunate but I don't see any alternative either.
| @@ -115,6 +115,7 @@ graphService: | |||
| searchService: | |||
| resultBatchSize: ${SEARCH_SERVICE_BATCH_SIZE:100} | |||
| enableCache: ${SEARCH_SERVICE_ENABLE_CACHE:false} | |||
| enableEviction: ${SEARCH_SERVICE_ENABLE_CACHE_EVICTION:false} | |||
There was a problem hiding this comment.
Once included in a release, we'll want to update our helm chart to support enabling it.
david-leifker
approved these changes
Mar 6, 2025
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
chakru-r
force-pushed
the
iceberg-cache-invalidation
branch
from
615dfc0 to
b31f1f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist