-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(restore-indices): createDefaultAspects argument #12859
Merged
david-leifker
merged 5 commits into
datahub-project:master
from
david-leifker:ensure-read-only-restore-indices
Mar 13, 2025
Merged
feat(restore-indices): createDefaultAspects argument #12859
david-leifker
merged 5 commits into
datahub-project:master
from
david-leifker:ensure-read-only-restore-indices
Mar 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
927fdf9
to
f2e0fd9
Compare
RyanHolstien
approved these changes
Mar 12, 2025
e884040
to
a229d65
Compare
Codecov ReportAttention: Patch coverage is ❌ Your patch check has failed because the patch coverage (40.81%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Codecov seems wrong/stale. The createDefaultAspects is in fact covered by a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devops
PR or Issue related to DataHub backend & deployment
docs
Issues and Improvements to docs
pending-submitter-merge
product
PR or Issue related to the DataHub UI/UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist