Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(restore-indices): createDefaultAspects argument #12859

Conversation

david-leifker
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added docs Issues and Improvements to docs product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Mar 12, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Mar 12, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Mar 12, 2025
@david-leifker david-leifker force-pushed the ensure-read-only-restore-indices branch from e884040 to a229d65 Compare March 13, 2025 00:21
@david-leifker david-leifker changed the title feat(restore-indices): SQL read-only mode feat(restore-indices): createDefaultAspects argument Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 40.81633% with 29 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...om/linkedin/metadata/entity/EntityServiceImpl.java 15.38% 21 Missing and 1 partial ⚠️
.../linkedin/metadata/resources/operations/Utils.java 0.00% 2 Missing ⚠️
...data/entity/restoreindices/RestoreIndicesArgs.java 0.00% 2 Missing ⚠️
...ld/GenerateSchemaFieldsFromSchemaMetadataStep.java 0.00% 1 Missing ⚠️
...edin/metadata/resources/entity/AspectResource.java 0.00% 1 Missing ⚠️
...adata/resources/operations/OperationsResource.java 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (40.81%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@david-leifker
Copy link
Collaborator Author

Codecov seems wrong/stale. The createDefaultAspects is in fact covered by a test.

@david-leifker david-leifker merged commit 463803e into datahub-project:master Mar 13, 2025
50 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants