feat(openapi): Adding subtype for openapi source #12873
Open
+294
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
commented
Mar 13, 2025
| @@ -8,9 +8,6 @@ | |||
| from typing import Dict, Iterable, List, Optional, Set, Union | |||
|
|
|||
| import nest_asyncio | |||
| from okta.client import Client as OktaClient | |||
There was a problem hiding this comment.
pylint insisted upon this in order to let me commit
There was a problem hiding this comment.
good with me, as long as ruff is happy with it
gabe-lyons
commented
Mar 13, 2025
|
|
||
| from datahub.ingestion.run.pipeline import Pipeline | ||
| from datahub.ingestion.source.identity.okta import OktaConfig | ||
| from okta.models import Group, User |
There was a problem hiding this comment.
pylint insisted upon this in order to let me commit
gabe-lyons
commented
Mar 13, 2025
| ] | ||
| } | ||
| }, | ||
| "entityType": "dataset", |
There was a problem hiding this comment.
I did visual validation that the metadata here is unchanged (save subtypes) and just re-organized.
|
lint issues are unrelated. |
github-actions
bot
added
the
ingestion
hsheth2
approved these changes
Mar 13, 2025
| @@ -8,9 +8,6 @@ | |||
| from typing import Dict, Iterable, List, Optional, Set, Union | |||
|
|
|||
| import nest_asyncio | |||
| from okta.client import Client as OktaClient | |||
There was a problem hiding this comment.
good with me, as long as ruff is happy with it
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff is so large because I had to refactor the openapi source to use MCP instead of MCE. The actual change is very minimal: just adding subtype.
Checklist