Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/redash): Limit size of RedashSourceReport #9873

Merged
merged 1 commit into from
Feb 21, 2024
+3 −2
Merged

fix(ingest/redash): Limit size of RedashSourceReport #9873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions metadata-ingestion/src/datahub/ingestion/source/redash.py
View file
Original file line number Diff line number Diff line change
@@ -39,6 +39,7 @@
ChartTypeClass,
DashboardInfoClass,
)
from datahub.utilities.lossy_collections import LossyDict, LossyList
from datahub.utilities.perf_timer import PerfTimer
from datahub.utilities.sql_parser import SQLParser

@@ -282,7 +283,7 @@ class RedashConfig(ConfigModel):
@dataclass
class RedashSourceReport(SourceReport):
items_scanned: int = 0
filtered: List[str] = field(default_factory=list)
filtered: LossyList[str] = field(default_factory=LossyList)
queries_problem_parsing: Set[str] = field(default_factory=set)
queries_no_dataset: Set[str] = field(default_factory=set)
charts_no_input: Set[str] = field(default_factory=set)
@@ -295,7 +296,7 @@ class RedashSourceReport(SourceReport):
)
max_page_dashboards: Optional[int] = field(default=None)
api_page_limit: Optional[float] = field(default=None)
timing: Dict[str, int] = field(default_factory=dict)
timing: LossyDict[str, int] = field(default_factory=LossyDict)

def report_item_scanned(self) -> None:
self.items_scanned += 1