Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: BI-0 Bump Trino version 468 -> 471 #858

Merged
merged 1 commit into from
Feb 25, 2025
Merged

test: BI-0 Bump Trino version 468 -> 471 #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/dl_connector_trino/dl_connector_trino/formula/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@


class TrinoDialect(DialectNamespace):
TRINO_468 = simple_combo(name=DIALECT_NAME_TRINO, version=(468,))
TRINO = TRINO_468
TRINO_471 = simple_combo(name=DIALECT_NAME_TRINO, version=(471,))
TRINO = TRINO_471
8 changes: 4 additions & 4 deletions lib/dl_connector_trino/dl_connector_trino_tests/db/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ class CoreJwtConnectionSettings(CoreSslConnectionSettings):


DB_URLS = {
D.TRINO_468: f"trino://datalens@" f'{get_test_container_hostport("trino-no-auth", fallback_port=21123).as_pair()}',
(D.TRINO_468, "ssl"): f"trino://trino_user@"
D.TRINO: f"trino://datalens@" f'{get_test_container_hostport("trino-no-auth", fallback_port=21123).as_pair()}',
(D.TRINO, "ssl"): f"trino://trino_user@"
f'{get_test_container_hostport("trino-tls-nginx", fallback_port=21124).as_pair()}',
}
DB_CORE_URL = DB_URLS[D.TRINO_468]
DB_CORE_SSL_URL = DB_URLS[(D.TRINO_468, "ssl")]
DB_CORE_URL = DB_URLS[D.TRINO]
DB_CORE_SSL_URL = DB_URLS[(D.TRINO, "ssl")]

API_TEST_CONFIG = ApiTestEnvironmentConfiguration(
api_connector_ep_names=["trino"],
Expand Down
8 changes: 4 additions & 4 deletions lib/dl_connector_trino/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
services:
trino-no-auth:
# image: "trinodb/trino:468"
# image: "trinodb/trino:471"
build:
context: docker-compose
dockerfile: Dockerfile.engine-trino-no-auth-468
dockerfile: Dockerfile.engine-trino-no-auth-471
depends_on:
- db-mysql-8-0
ports:
- "21123:8080"

trino:
# image: "trinodb/trino:468"
# image: "trinodb/trino:471"
build:
context: docker-compose
dockerfile: Dockerfile.engine-trino-468
dockerfile: Dockerfile.engine-trino-471
depends_on:
- db-mysql-8-0

Expand Down
2 changes: 1 addition & 1 deletion ...ocker-compose/Dockerfile.engine-trino-468 → ...ocker-compose/Dockerfile.engine-trino-471
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM trinodb/trino:468@sha256:a2b6d3d46c2776c9c1ec3dcdac170d19f98dc538f2c9f2c454f2a364e7f37b87
FROM trinodb/trino:471@sha256:23b08b7d42978e12493a271d49288ecb31aa36bc3fcf736cbf0e9960698f7f01

COPY trino/config/* /etc/trino/
COPY trino/catalog/* /etc/trino/catalog/
Expand Down
2 changes: 1 addition & 1 deletion ...mpose/Dockerfile.engine-trino-no-auth-468 → ...mpose/Dockerfile.engine-trino-no-auth-471
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM trinodb/trino:468@sha256:a2b6d3d46c2776c9c1ec3dcdac170d19f98dc538f2c9f2c454f2a364e7f37b87
FROM trinodb/trino:471@sha256:23b08b7d42978e12493a271d49288ecb31aa36bc3fcf736cbf0e9960698f7f01

COPY trino/no_auth_config/* /etc/trino/
COPY trino/catalog/* /etc/trino/catalog/
Expand Down
Loading