Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-RegistryPropertyValue: Add new command #141

Merged
merged 7 commits into from
Mar 9, 2025

Conversation

johlju
Copy link
Member

@johlju johlju commented Mar 9, 2025

Pull Request (PR) description

Added

  • DscResource.Common
    • Added GitHub issue template for new command proposals.
    • Patch ModuleBuilder to workaround issue #135.
    • Public command:
      • Get-RegistryPropertyValue - Get a registry property value.

Changed

  • Compare-DscParameterState
    • Updated comment-based help example.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93%. Comparing base (8b170c8) to head (29cfebb).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #141   +/-   ##
===================================
  Coverage    92%    93%           
===================================
  Files        41     42    +1     
  Lines       705    719   +14     
===================================
+ Hits        655    669   +14     
  Misses       50     50           
Files with missing lines Coverage Δ
source/Public/Compare-DscParameterState.ps1 85% <ø> (ø)
source/Public/Get-RegistryPropertyValue.ps1 100% <100%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit d48e4bd into dsccommunity:main Mar 9, 2025
11 checks passed
@johlju johlju deleted the f/issue#139 branch March 9, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-RegistryPropertyValue: New command suggestion
1 participant