Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merger PHO cWebsite to xWebsite #8

Closed
wants to merge 2 commits into from
Closed

Merger PHO cWebsite to xWebsite #8

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 24, 2015

This merges the work done on Powershell.orgs cWebsite resource https://github.com/PowerShellOrg/cWebAdministration/tree/master/DSCResources/PSHOrg_cWebsite. There was an issue with xWebsite default page option that I haven't been able to track down. So I removed that option since it can also be accomplished by using the webConfigProp settings.

@msftclas
Copy link

Hi @zuehlaa, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@vors
Copy link
Contributor

vors commented Apr 27, 2015

Please, fix tests. Running common tests locally

@TravisEz13 TravisEz13 added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label May 23, 2015
@kevinsea
Copy link

The web configuration properties in this merge request have type cast issues. I found it did not work for many properties I was trying to test. I have a pull request pending in the powershell.org repo that fixes the problems I found. It is big change, but it may be a better merge source.

https://github.com/PowerShellOrg/cWebAdministration/pull/21

@tysonjhayes
Copy link

Hi @zuehlaa - are you still working on this? It's been a while since we've seen any activity on this. If you are not working on this anymore (or I don't hear from you) I'm going to fork this and try to fix it up myself as we'd really like some of this functionality. Please let me know.

@ghost
Copy link
Author

ghost commented Nov 19, 2015

I've been waiting to hear back from @KarolKaczmarek or @TravisEz13 on #7 (comment) before doing any more work on this one

@tysonjhayes
Copy link

Thanks, as noted in the other PR if you could get the merge conflicts resolve and this updated I'll try to help you get this sorted out.

@nzspambot
Copy link

@zuehlaa can you check out #65 as there is a fix in there which may or may not be backwards portable to your branch

@TravisEz13
Copy link
Contributor

@tysonjhayes @zuehlaa I reviewed the other mentioned PR. I'm not sure what this is waiting on. So, I'll comment on the issues that I see.

@zuehlaa
Please resolve merge conflicts. For more information see GitHowTo - 30. Resolving Conflicts

It is required that you provide adequate test coverage for the code you change. Contribution Guidelines -Adding test coverage for DSC resources Please work with us to come up with a plan to cover this code.

If there is no update of the pull request within 7 days, we will close the pull request. After that, if you have an update, feel free to reopen the pull request.

@TravisEz13
Copy link
Contributor

Closing because the pull request has not been updated for feedback given for 21 days. Once you update the code, please feel free to reopen the pull request. Thanks, Travis.

@TravisEz13 TravisEz13 closed this Jan 28, 2016
@TravisEz13 TravisEz13 removed the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants