-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merger PHO cWebsite to xWebsite #8
Conversation
Hi @zuehlaa, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
Please, fix tests. Running common tests locally |
The web configuration properties in this merge request have type cast issues. I found it did not work for many properties I was trying to test. I have a pull request pending in the powershell.org repo that fixes the problems I found. It is big change, but it may be a better merge source. |
Hi @zuehlaa - are you still working on this? It's been a while since we've seen any activity on this. If you are not working on this anymore (or I don't hear from you) I'm going to fork this and try to fix it up myself as we'd really like some of this functionality. Please let me know. |
I've been waiting to hear back from @KarolKaczmarek or @TravisEz13 on #7 (comment) before doing any more work on this one |
Thanks, as noted in the other PR if you could get the merge conflicts resolve and this updated I'll try to help you get this sorted out. |
@zuehlaa can you check out #65 as there is a fix in there which may or may not be backwards portable to your branch |
@tysonjhayes @zuehlaa I reviewed the other mentioned PR. I'm not sure what this is waiting on. So, I'll comment on the issues that I see. @zuehlaa It is required that you provide adequate test coverage for the code you change. Contribution Guidelines -Adding test coverage for DSC resources Please work with us to come up with a plan to cover this code. If there is no update of the pull request within 7 days, we will close the pull request. After that, if you have an update, feel free to reopen the pull request. |
Closing because the pull request has not been updated for feedback given for 21 days. Once you update the code, please feel free to reopen the pull request. Thanks, Travis. |
This merges the work done on Powershell.orgs cWebsite resource https://github.com/PowerShellOrg/cWebAdministration/tree/master/DSCResources/PSHOrg_cWebsite. There was an issue with xWebsite default page option that I haven't been able to track down. So I removed that option since it can also be accomplished by using the webConfigProp settings.