Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue667 - Add global_data_tags to fleet agent policies #1044

Open
wants to merge 83 commits into
base: main
Choose a base branch
from

Conversation

Zyther
Copy link

@Zyther Zyther commented Mar 5, 2025

Whew.

Picking up from where @mholttech left off, this implements global data tags on the agent policy resource.

This change:

  • implements Issue 667
  • Modifies CRUD of agent policies to include a global_data_tags block, if it exists
  • asks for a nested attribute object at the hcl/tf resource level
  • updates kibana.gen.go to 3757e641278a5186919e35a0f980ac3cda7e8ccd
  • links the global data tags schemas together (post, put, get) so they can be used to marshal/unmarshal universally

Thanks! Let me know what else is needed.

Copy link

cla-checker-service bot commented Mar 5, 2025

💚 CLA has been signed

@Zyther
Copy link
Author

Zyther commented Mar 5, 2025

oi, need to fix this. apologies

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! A couple of small changes before we can get this merged.

@Zyther
Copy link
Author

Zyther commented Mar 21, 2025

All set! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support data tagging/add_field in Agent Policy (8.15)
3 participants