chore: replicas using values.yaml + enable leader election #501
Conversation
…tion Signed-off-by: Rajat Vig <[email protected]>
rajatvig
changed the title
rajatvig
changed the title
rajatvig
changed the title
| @@ -42,6 +43,7 @@ spec: | |||
| - -logLevel={{ .Values.controller.logLevel }} | |||
| - --extProcImage={{ .Values.extProc.repository }}:{{ .Values.extProc.tag | default .Chart.AppVersion }} | |||
| - --extProcLogLevel={{ .Values.extProc.logLevel }} | |||
| - --enableLeaderElection=true | |||
There was a problem hiding this comment.
Can we make it configurable ?
There was a problem hiding this comment.
That is possible though with > 1 replica, having leader election is required. Do you think it would be better to have that as a conditional here, i.e., always turn it on if there is > 1 replica but not add it if there is only 1?
There was a problem hiding this comment.
I think it won't hurt to enable this by default ?
There was a problem hiding this comment.
is this for the ai-controller ? then you'd have to do extra work in code, to detect the leader election and based on that, only allow the leader to generate the Gateway API resources
There was a problem hiding this comment.
yeah controller and i believe it's already handled assuming leader election = true (i don't remember precisely;)), and the current default is true:
ai-gateway/cmd/controller/main.go
Line 50 in f3ab8bb
There was a problem hiding this comment.
Would I be correct in assuming then that the change is safe to do and this pull request looks fine?
There was a problem hiding this comment.
yeah I think so, but deferring to @yuzisun for the final approval
There was a problem hiding this comment.
@rajatvig You can set the default to true in values.yaml, otherwise there is no way to disable it if needed.
There was a problem hiding this comment.
Have changed the code per suggestion.
Commit Message
Set deployment replicas based off the
values.yamland enable leader election for the controller.Signed-off-by: Rajat Vig [email protected]