Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: host header should not be allowed to modify #5533

Merged
merged 2 commits into from
Mar 21, 2025
Merged

fix: host header should not be allowed to modify #5533

merged 2 commits into from
Mar 21, 2025

Conversation

zhaohuabing
Copy link
Member

Fix: #5182

@zhaohuabing zhaohuabing requested a review from a team as a code owner March 18, 2025 06:17
@zhaohuabing
host header is not allowed to be modified
8aac49c 
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
@zhaohuabing zhaohuabing changed the title fix: host header is not allowed to be modified fix: host header shout not be allowed to modify Mar 18, 2025
@zhaohuabing zhaohuabing changed the title fix: host header shout not be allowed to modify fix: host header should not be allowed to modify Mar 18, 2025
@zhaohuabing zhaohuabing marked this pull request as draft March 18, 2025 06:24
@zhaohuabing zhaohuabing marked this pull request as ready for review March 18, 2025 06:28
@codecov Codecov
Copy link

codecov bot commented Mar 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.95489% with 24 lines in your changes missing coverage. Please review.

Project coverage is 65.21%. Comparing base (fcdab90) to head (653e9a5).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/filters.go 81.95% 24 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5533      +/-   ##
==========================================
+ Coverage   65.20%   65.21%   +0.01%     
==========================================
  Files         213      213              
  Lines       34033    33954      -79     
==========================================
- Hits        22191    22143      -48     
+ Misses      10516    10485      -31     
  Partials     1326     1326

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

guydc
guydc previously approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaohuabing
address comment
653e9a5 
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
@zhaohuabing zhaohuabing requested review from guydc and arkodg March 21, 2025 03:24
arkodg
arkodg approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@zhaohuabing zhaohuabing merged commit 54efa34 into envoyproxy:main Mar 21, 2025
25 checks passed
@zhaohuabing zhaohuabing deleted the fix-5182 branch March 21, 2025 04:14
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Mar 21, 2025
@zhaohuabing
fix: host header should not be allowed to modify (envoyproxy#5533)
5214652 
* host header is not allowed to be modified

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* address comment

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

---------

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
(cherry picked from commit 54efa34)
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
guydc pushed a commit to guydc/gateway that referenced this pull request Mar 21, 2025
@zhaohuabing @guydc
fix: host header should not be allowed to modify (envoyproxy#5533)
33dfe8d 
* host header is not allowed to be modified

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* address comment

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

---------

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
(cherry picked from commit 54efa34)
Signed-off-by: Guy Daich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zirain zirain zirain approved these changes

@arkodg arkodg arkodg approved these changes

@guydc guydc Awaiting requested review from guydc

Assignees
No one assigned
Labels
cherrypick/release-v1.2.8 cherrypick/release-v1.3.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

problem with all routes 404 when using incorrect filters
4 participants
@zhaohuabing @zirain @arkodg @guydc