Removes inline os.Stdout as log output #5550
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plz fix the CI failures @mathetake |
|
yeah sorry done |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (52.63%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5550 +/- ##
==========================================
+ Coverage 65.25% 65.36% +0.10%
==========================================
Files 213 213
Lines 34063 34067 +4
==========================================
+ Hits 22228 22268 +40
+ Misses 10500 10473 -27
+ Partials 1335 1326 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
|
great |
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
zirain
force-pushed
the
loggeroutputcentralize
branch
from
dc5ff70 to
fe89f67
Compare
zirain
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
refactor: removes inline os.Stdout as log output
What this PR does / why we need it:
This removes the (almost) remaining places where the logger is configured to use os.Stdout instead of the configured output inherited from the cobra command. Without this change, the logging destination is scattered randomly from the downstream user's perspective. This is a follow up on #5476 #5483 and eliminates almost all places using os.Stdout except for the global loggers in a few places plus the stdout for the standalone mode's Envoy process. The implementation should be agnostic to any io.Writer in reality and there shouldn't be any necessity to directly use os.Stdout for all cases.