Update CSS to address non-clickable links before td-content>h2 #5554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gauthier Wallet <gauthier.wallet@gmail.com>
Ninir
changed the title
Ninir
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5554 +/- ##
==========================================
- Coverage 65.22% 65.22% -0.01%
==========================================
Files 213 213
Lines 34106 34106
==========================================
- Hits 22247 22245 -2
- Misses 10531 10536 +5
+ Partials 1328 1325 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
cc @missBerg |
|
thanks for catching! LGMT! |
arkodg
approved these changes
Mar 21, 2025
zirain
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is impacting all pages where the h2 block is overlapping a links, e.g https://gateway.envoyproxy.io/latest/tasks/traffic/backend/, https://gateway.envoyproxy.io/latest/tasks/traffic/client-traffic-policy/, https://gateway.envoyproxy.io/latest/tasks/security/backend-tls/
See this video to better understand it (I first refresh the page, then try to click/double-click the link, which shows the title being highlighted):
Screen.Recording.2025-03-20.at.12.50.14.PM.mov
What this PR does / why we need it:
This fixes non-clickable links due to the title overlapping (with higher z-index)
Which issue(s) this PR fixes:
Release Notes: No