api: access log disabled should be optional #5564
Conversation
Signed-off-by: zirain <zirain2009@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5564 +/- ##
==========================================
+ Coverage 65.19% 65.21% +0.01%
==========================================
Files 213 213
Lines 34111 33954 -157
==========================================
- Hits 22238 22142 -96
+ Misses 10545 10485 -60
+ Partials 1328 1327 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkodg
changed the title
| @@ -266,7 +266,7 @@ func (t *Translator) processAccessLog(envoyproxy *egv1a1.EnvoyProxy, resources * | |||
| if envoyproxy == nil || | |||
| envoyproxy.Spec.Telemetry == nil || | |||
| envoyproxy.Spec.Telemetry.AccessLog == nil || | |||
| (!envoyproxy.Spec.Telemetry.AccessLog.Disable && len(envoyproxy.Spec.Telemetry.AccessLog.Settings) == 0) { | |||
| (!ptr.Deref(envoyproxy.Spec.Telemetry.AccessLog.Disable, false) && len(envoyproxy.Spec.Telemetry.AccessLog.Settings) == 0) { | |||
There was a problem hiding this comment.
Can we add/modify a gateway api test, where this is omitted from input testdata with no change in out?
There was a problem hiding this comment.
sorry, I didn't get your point.
There was a problem hiding this comment.
@zirain We don't seem to have a test for this, can we have a test with accessLog: {}. Modifying an existing test with enabled access logs should work.
gateway/internal/gatewayapi/testdata/disable-accesslog.in.yaml
Lines 9 to 10 in 54efa34
|
/retest |
fixes: #5553