Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for multi-region setups and added Error Handling #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

silvanm
Copy link

@silvanm silvanm commented Jan 18, 2025

Changes

  • Initialization: Implemented top-level async initialization with global variables for better state management
  • File System: Added robust path resolution and detailed error handling for key file access
  • Location Validation: Added comprehensive list of valid BigQuery locations and switched default to 'EU'
  • Error Handling: Enhanced error messages with specific details for different failure scenarios

These changes improve reliability and provide better feedback for configuration issues.

Copy link

@0anton 0anton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I‘m not the code owner, but this PR is lgtm.

@ngohuuduc
Copy link

This change is not yet merge ?

@silvanm
Copy link
Author

silvanm commented Mar 14, 2025

As suggested in #4 (comment) I have now pushed the following changes:

  1. Removed Location Validation:
  • Removed the list of valid BigQuery locations that was previously used for validation
  • Removed the validation check that would throw an error if an invalid location was provided
  1. Changed Default Location:
  • Changed the default location from 'EU' to 'US'

@ngohuuduc
Copy link

Hello, I have clone the project from @silvanm and tried to run it on my local. The tsconfig.json needs to be updated as well to handle for some

"module": "NodeNext" → Allows top-level await in Node.js.

"moduleResolution": "NodeNext" → Required when using "module": "NodeNext".

"target": "ES2022" → Ensures modern JavaScript syntax is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants