-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating metrics documentation #4504
base: feature/listeners
Are you sure you want to change the base?
Conversation
70db542
to
c172f67
Compare
c172f67
to
8133ab0
Compare
59df71b
to
60bc929
Compare
60bc929
to
d5d2dcb
Compare
d5d2dcb
to
9df575b
Compare
elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 9df575b small_tests_27 / small_tests / 9df575b small_tests_26 / small_tests / 9df575b small_tests_27_arm64 / small_tests / 9df575b ldap_mnesia_26 / ldap_mnesia / 9df575b pubsub_SUITE:dag+basic:create_delete_node_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,445}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,435}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,425}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,75}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} ldap_mnesia_27 / ldap_mnesia / 9df575b dynamic_domains_mysql_redis_27 / mysql_redis / 9df575b internal_mnesia_27 / internal_mnesia / 9df575b dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 9df575b dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 9df575b pgsql_cets_27 / pgsql_cets / 9df575b dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 9df575b mysql_redis_27 / mysql_redis / 9df575b pgsql_mnesia_26 / pgsql_mnesia / 9df575b cockroachdb_cets_27 / cockroachdb_cets / 9df575b pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_send_last_published_item_no_items_test_3763@localhost/res1">>,
escalus_tcp,<0.118430.0>,
[{event_manager,<0.118419.0>},
{server,<<"localhost">>},
{username,
<<"alicE_send_last_published_item_no_items_test_3763">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.118419.0>},
{server,<<"localhost">>},
{username,
<<"alicE_send_last_published_item_no_items_test_3763">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_send_last_published_item_no_items_test_3763">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,fun escalus_auth:auth_plain/2},
{wspath,undefined},
{username,
<<"alicE_send_last_published_item_no_items_test_3763">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"f01ccd1860cd23f6">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_c... mssql_mnesia_27 / odbc_mssql_mnesia / 9df575b graphql_last_SUITE:user:user_last:user_get_other_user_last{error,{{badmatch,null},
[{graphql_last_SUITE,user_get_other_user_last_story,3,
[{file,"/home/circleci/project/big_tests/tests/graphql_last_SUITE.erl"},
{line,540}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,75}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}} pgsql_mnesia_27 / pgsql_mnesia / 9df575b small_tests_27_arm64 / small_tests / 9df575b ldap_mnesia_26 / ldap_mnesia / 9df575b mssql_mnesia_27 / odbc_mssql_mnesia / 9df575b |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/listeners #4504 +/- ##
=====================================================
- Coverage 85.85% 85.80% -0.05%
=====================================================
Files 564 564
Lines 33824 33821 -3
=====================================================
- Hits 29039 29021 -18
- Misses 4785 4800 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
this PR addresses the following things:
connection_type => http
metrics since they duplicate existing mod_bosh_data_* and mod_websocket_data_* metrics and introduce inconsitency inconnection_type
label interpretation for various metrics.mongoose_c2s
module, because it was impossible to configure websockets/bosh connection without tcp/tls c2s connection (even if tcp/tls c2s connection is not needed)