Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating metrics documentation #4504

Open
wants to merge 3 commits into
base: feature/listeners
Choose a base branch
from

Conversation

DenysGonchar
Copy link
Collaborator

@DenysGonchar DenysGonchar commented Mar 11, 2025

this PR addresses the following things:

  • updates description of the listeners' metrics.
  • removes connection_type => http metrics since they duplicate existing mod_bosh_data_* and mod_websocket_data_* metrics and introduce inconsitency in connection_type label interpretation for various metrics.
  • moves back c2s specific metrics definition into mongoose_c2s module, because it was impossible to configure websockets/bosh connection without tcp/tls c2s connection (even if tcp/tls c2s connection is not needed)

@DenysGonchar DenysGonchar force-pushed the documenting_metrics_changes branch from 70db542 to c172f67 Compare March 12, 2025 11:51
@DenysGonchar DenysGonchar changed the title extending exometer_labels convertor updating metrics documentation Mar 12, 2025
@esl esl deleted a comment from mongoose-im Mar 12, 2025
@esl esl deleted a comment from codecov bot Mar 12, 2025
@esl esl deleted a comment from mongoose-im Mar 12, 2025
@esl esl deleted a comment from mongoose-im Mar 12, 2025
@esl esl deleted a comment from mongoose-im Mar 12, 2025
@DenysGonchar DenysGonchar force-pushed the documenting_metrics_changes branch from c172f67 to 8133ab0 Compare March 13, 2025 14:16
@DenysGonchar DenysGonchar force-pushed the documenting_metrics_changes branch 2 times, most recently from 59df71b to 60bc929 Compare March 14, 2025 19:44
@esl esl deleted a comment from mongoose-im Mar 14, 2025
@esl esl deleted a comment from mongoose-im Mar 14, 2025
@esl esl deleted a comment from codecov bot Mar 14, 2025
@DenysGonchar DenysGonchar force-pushed the documenting_metrics_changes branch from 60bc929 to d5d2dcb Compare March 14, 2025 20:42
@esl esl deleted a comment from mongoose-im Mar 14, 2025
@esl esl deleted a comment from mongoose-im Mar 14, 2025
@esl esl deleted a comment from codecov bot Mar 14, 2025
@esl esl deleted a comment from mongoose-im Mar 14, 2025
@esl esl deleted a comment from mongoose-im Mar 14, 2025
@DenysGonchar DenysGonchar force-pushed the documenting_metrics_changes branch from d5d2dcb to 9df575b Compare March 14, 2025 22:51
@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 14, 2025

elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 9df575b
Reports root/ big
OK: 683 / Failed: 0 / User-skipped: 72 / Auto-skipped: 0


small_tests_27 / small_tests / 9df575b
Reports root / small


small_tests_26 / small_tests / 9df575b
Reports root / small


small_tests_27_arm64 / small_tests / 9df575b
Reports root / small


ldap_mnesia_26 / ldap_mnesia / 9df575b
Reports root/ big
OK: 2299 / Failed: 1 / User-skipped: 1187 / Auto-skipped: 0

pubsub_SUITE:dag+basic:create_delete_node_test
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,445}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,435}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,425}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1234}]}]}}

Report log


ldap_mnesia_27 / ldap_mnesia / 9df575b
Reports root/ big
OK: 2300 / Failed: 0 / User-skipped: 1352 / Auto-skipped: 0


dynamic_domains_mysql_redis_27 / mysql_redis / 9df575b
Reports root/ big
OK: 5140 / Failed: 0 / User-skipped: 154 / Auto-skipped: 0


internal_mnesia_27 / internal_mnesia / 9df575b
Reports root/ big
OK: 2434 / Failed: 0 / User-skipped: 1218 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 9df575b
Reports root/ big
OK: 5010 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 9df575b
Reports root/ big
OK: 5175 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


pgsql_cets_27 / pgsql_cets / 9df575b
Reports root/ big
OK: 5249 / Failed: 0 / User-skipped: 188 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 9df575b
Reports root/ big
OK: 5170 / Failed: 0 / User-skipped: 124 / Auto-skipped: 0


mysql_redis_27 / mysql_redis / 9df575b
Reports root/ big
OK: 5531 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 9df575b
Reports root/ big
OK: 5387 / Failed: 0 / User-skipped: 128 / Auto-skipped: 0


cockroachdb_cets_27 / cockroachdb_cets / 9df575b
Reports root/ big
OK: 5251 / Failed: 1 / User-skipped: 188 / Auto-skipped: 0

pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3763@localhost/res1">>,
          escalus_tcp,<0.118430.0>,
          [{event_manager,<0.118419.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3763">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.118419.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3763">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3763">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,fun escalus_auth:auth_plain/2},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3763">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"f01ccd1860cd23f6">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,434}]},
     {pubsub_tools,receive_and_c...

Report log


mssql_mnesia_27 / odbc_mssql_mnesia / 9df575b
Reports root/ big
OK: 5546 / Failed: 1 / User-skipped: 133 / Auto-skipped: 0

graphql_last_SUITE:user:user_last:user_get_other_user_last
{error,{{badmatch,null},
    [{graphql_last_SUITE,user_get_other_user_last_story,3,
               [{file,"/home/circleci/project/big_tests/tests/graphql_last_SUITE.erl"},
                {line,540}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log


pgsql_mnesia_27 / pgsql_mnesia / 9df575b
Reports root/ big
OK: 5552 / Failed: 0 / User-skipped: 128 / Auto-skipped: 0


small_tests_27_arm64 / small_tests / 9df575b
Reports root / small


ldap_mnesia_26 / ldap_mnesia / 9df575b
Reports root/ big
OK: 2300 / Failed: 0 / User-skipped: 1187 / Auto-skipped: 0


mssql_mnesia_27 / odbc_mssql_mnesia / 9df575b
Reports root/ big
OK: 5547 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.80%. Comparing base (d5662df) to head (9df575b).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           feature/listeners    #4504      +/-   ##
=====================================================
- Coverage              85.85%   85.80%   -0.05%     
=====================================================
  Files                    564      564              
  Lines                  33824    33821       -3     
=====================================================
- Hits                   29039    29021      -18     
- Misses                  4785     4800      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DenysGonchar DenysGonchar marked this pull request as ready for review March 15, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants