Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cpp submodule #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Mar 18, 2025

This also tests all of our CI to ensure the process works.

  • Some good overall practices - guide (I put it together, so there might be some mistakes)
  • It is usually best to let the author of the PR merge it themselves IF they have the rights to do so. But only after it gets approved. This way the author stays responsible for their work. If a contribution is from an outside contributor, one of the maintainers must take over that work.

There are a few additional things we will need to do - i'll create issues for those

@nyurik nyurik requested review from lemire and jjcfrancisco March 18, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant