Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use @fastify/error to create errors #179

Merged
merged 1 commit into from
Mar 10, 2024
Merged

fix: Use @fastify/error to create errors #179

merged 1 commit into from
Mar 10, 2024

Conversation

dancastillo
Copy link
Member

Work done: Use @fastify/error to create errors FST_BEARER_AUTH_MISSING_AUTH…ORIZATION_HEADER and FST_BEARER_AUTH_INVALID_AUTHORIZATION_HEADER
Closes: #178

Checklist

@dancastillo
fix: Use @fastify/error to create errors FST_BEARER_AUTH_MISSING_AUTH…
f6a626e 
…ORIZATION_HEADER and FST_BEARER_AUTH_INVALID_AUTHORIZATION_HEADER
gurgunday
gurgunday approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should we capitalize the messages or is it fine?

https://github.com/fastify/fastify-bearer-auth/pull/179/files#diff-0af7067b49efcaf7dae9a3707f2e79638b336e72780d2b834e007f80ef9a5fa0R9-R10

mcollina
mcollina approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak
Copy link
Contributor

Uzlopak commented Mar 10, 2024

lgtm, should we capitalize the messages or is it fine?

https://github.com/fastify/fastify-bearer-auth/pull/179/files#diff-0af7067b49efcaf7dae9a3707f2e79638b336e72780d2b834e007f80ef9a5fa0R9-R10

image

Uzlopak
Uzlopak approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit 2fbe43c into fastify:master Mar 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use @fastify/error to create errors
4 participants
@dancastillo @Uzlopak @mcollina @gurgunday