Code Quality: Use SettingsCard/SettingsExpander from WCT 8 #16971
+594
−620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gus33000's settings controls have served well! |
yaira2
force-pushed
the
main
branch
7 times, most recently
from
30cea65 to
decf3da
Compare
yaira2
reviewed
Mar 25, 2025
|
|
||
| <!-- Title --> | ||
| <TextBlock | ||
| Padding="0,0,0,12" | ||
| FontSize="24" | ||
| FontWeight="Medium" | ||
| Style="{StaticResource TitleTextBlockStyle}" |
There was a problem hiding this comment.
Suggested change
| Style="{StaticResource TitleTextBlockStyle}" | |
| FontSize="24" | |
| FontWeight="Medium" |
yaira2
reviewed
Mar 25, 2025
Comment on lines
+65
to
+66
| Padding="0,20,0,4" | ||
| Style="{StaticResource BodyStrongTextBlockStyle}" |
There was a problem hiding this comment.
Suggested change
| Padding="0,20,0,4" | |
| Style="{StaticResource BodyStrongTextBlockStyle}" | |
| Padding="0,16,0,4" | |
| FontSize="16" | |
| FontWeight="Medium" |
yaira2
reviewed
Mar 25, 2025
Comment on lines
+137
to
+138
| Padding="0,20,0,4" | ||
| Style="{StaticResource BodyStrongTextBlockStyle}" |
There was a problem hiding this comment.
Suggested change
| Padding="0,20,0,4" | |
| Style="{StaticResource BodyStrongTextBlockStyle}" | |
| Padding="0,16,0,4" | |
| FontSize="16" | |
| FontWeight="Medium" |
yaira2
reviewed
Mar 25, 2025
|
|
||
| <!-- Title --> | ||
| <TextBlock | ||
| Padding="0,0,0,12" | ||
| FontSize="24" | ||
| FontWeight="Medium" | ||
| Style="{StaticResource TitleTextBlockStyle}" |
There was a problem hiding this comment.
Suggested change
| Style="{StaticResource TitleTextBlockStyle}" | |
| FontSize="24" | |
| FontWeight="Medium" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
None
Steps used to test these changes