Add field status.clusterSize
and CEL rule for spec.replicas
transitions
#1028
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality usability
/kind api-change enhancement
What this PR does / why we need it:
This PR adds a CEL rule to validate
spec.replicas
transitions, to ensure that transitions such as3->1
and1->0->3
are disallowed.To make this work for hibernated clusters whose replicas is set to 0, a new field
status.clusterSize
to record the etcd cluster size, independent of the replicas. For instance, when the Etcd is scaled from 3 to 0 replicas, the cluster size still remains 3.This PR also removes the
test
(test-unit) andtest_integration
steps from the concourse pipeline job, since these are now run as prow jobs and are stable.Which issue(s) this PR fixes:
Fixes partially #1022
Special notes for your reviewer:
Integration tests and documentation changes will soon follow.Added integration tests and doc changes. PR is still on hold until druid v0.28.0 is released./hold
Also, concourse steps
test
andtest_integration
will fail since the executable scripts for these steps have been removed in this PR, but the pipeline definition is fetched from master branch, so the pipeline still attempts to run these steps. Once this PR is merged, subsequent PRs will not face this issue.Release note: