Support secureboot on AWS #172
Merged
+44
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincinator
reviewed
Mar 3, 2025
glci/model.py
Outdated
| @@ -453,7 +453,7 @@ class ReleaseManifest(ReleaseIdentifier): | |||
| build_timestamp: str | |||
| paths: typing.Tuple[S3ReleaseFile, ...] | |||
| base_image: typing.Optional[str] | |||
|
|
|||
| secureboot: bool | |||
There was a problem hiding this comment.
Tried to understand, but couldn't:
where do we set the values for this data class?
Just wanted to check if and where we need to set the variable of secureboot.
just curious.
There was a problem hiding this comment.
The release manifest (those files on S3) are loaded into these dataclasses through the dacite library. That happens right here...
There was a problem hiding this comment.
Yes the decision whether to enable secureboot when publishing to providers is left to the build system. It outputs that information as a binary flag in the manifest. GLCI reads that and acts accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add secureboot support to GLCI and implement it for AWS
Which issue(s) this PR fixes:
Fixes #168
Release note: