changed where we cal the rescanning update text so it is not called w… #2061
+34
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen request fails
JR40159
requested changes
Mar 19, 2025
| @@ -75,7 +75,6 @@ export default function FileDownload({ modelId, file, showAssociatedReleases = f | |||
|
|
|||
| const handleRerunFileScanOnClick = useCallback(async () => { | |||
| const res = await rerunFileScan(modelId, (file as FileInterface)._id) | |||
There was a problem hiding this comment.
I think the root of the issue is that this request is currently just fire and forget. To make it more useful to the frontend and other clients, we should update it to return the update scan results. The backend already updates the scan results to be in progress but doesn't then return them
ARADDCC002
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hen request fails