-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made iptables initialization a bit more flexible #37
base: master
Are you sure you want to change the base?
Conversation
This enables configuration of which (if any) rules and chains should be removed. Enables usage alongside other tools that (dynamically) insert their rules like fail2ban or docker. The default behavior is following the previous functionality - removing all rules and non-default chains.
The logic is a bit more complicated now and it appears, that this flush will be performed on service start anyways, so I'm removing this step from the tasks.
Could be really interesting to prevent fail2ban & docker chain deletion each time that rules are updated. |
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark pull requests as stale. |
This is not stale. Something like this is very helpful when running on hosts using Docker, especially since this resets the |
This issue is no longer marked for closure. |
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark pull requests as stale. |
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details. |
any chance that this is merged upstream? We are hitting problems when applying this role in docker hosts |
This would solve the Docker problem nicely. @geerlingguy Could you please have a look (and prefetably explain to the bot it should not close it again ...). Thank you for your time! |
is this going to be re-opened? |
@geerlingguy is this going to be re-opened? Having the same problem with docker as probably everyone and this would solve that nicely. |
This feature would also be really useful for us |
This pull request is no longer marked for closure. |
Hi @geerlingguy, is this still planned? Anything missing? |
It has been a few years! Can we merge this? I need that functionality as well |
I tried resolving the merge conflicts—can someone confirm the changes are still working? Maybe I can merge it before the new year :D |
This enables configuration of which (if any) rules and chains should
be removed. Enables usage alongside other tools that (dynamically)
insert their rules like fail2ban or docker. The default behavior is
following the previous functionality - removing all rules and
non-default chains.
With proper configuration, this should solve issues in #31