Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made iptables initialization a bit more flexible #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mprasil
Copy link

@mprasil mprasil commented Apr 6, 2017

This enables configuration of which (if any) rules and chains should
be removed. Enables usage alongside other tools that (dynamically)
insert their rules like fail2ban or docker. The default behavior is
following the previous functionality - removing all rules and
non-default chains.

With proper configuration, this should solve issues in #31

mprasil added 2 commits April 6, 2017 14:33
This enables configuration of which (if any) rules and chains should
be removed. Enables usage alongside other tools that (dynamically)
insert their rules like fail2ban or docker. The default behavior is
following the previous functionality - removing all rules and
non-default chains.
The logic is a bit more complicated now and it appears, that this
flush will be performed on service start anyways, so I'm removing
this step from the tasks.
@romaindequidt
Copy link

Could be really interesting to prevent fail2ban & docker chain deletion each time that rules are updated.

@stale
Copy link

stale bot commented Mar 6, 2020

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Mar 6, 2020
@geerlingguy
Copy link
Owner

This is not stale. Something like this is very helpful when running on hosts using Docker, especially since this resets the DOCKER-USER chain, which might have important additional rules added.

@stale
Copy link

stale bot commented Mar 15, 2020

This issue is no longer marked for closure.

@stale
Copy link

stale bot commented Jun 13, 2020

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Jun 13, 2020
@stale
Copy link

stale bot commented Jul 13, 2020

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.

@stale stale bot closed this Jul 13, 2020
@pescobar
Copy link

any chance that this is merged upstream? We are hitting problems when applying this role in docker hosts

@spacekpe
Copy link

This would solve the Docker problem nicely. @geerlingguy Could you please have a look (and prefetably explain to the bot it should not close it again ...). Thank you for your time!

@pescobar
Copy link

is this going to be re-opened?

@brnck
Copy link

brnck commented Mar 26, 2021

@geerlingguy is this going to be re-opened? Having the same problem with docker as probably everyone and this would solve that nicely.

@pescobar
Copy link

This feature would also be really useful for us

@geerlingguy geerlingguy reopened this Mar 26, 2021
@stale
Copy link

stale bot commented Mar 26, 2021

This pull request is no longer marked for closure.

@stale stale bot removed the stale label Mar 26, 2021
@staticdev
Copy link

Hi @geerlingguy, is this still planned? Anything missing?

@katomaso
Copy link

katomaso commented Dec 1, 2022

It has been a few years! Can we merge this? I need that functionality as well

@geerlingguy
Copy link
Owner

I tried resolving the merge conflicts—can someone confirm the changes are still working? Maybe I can merge it before the new year :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants