Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(processor): Fix client handling and number of active connections #4597

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Mar 20, 2025

This PR fixes issues with the async processor in two ways:

  • It no longer holds the Redis client across await points, which previously caused a massive slowdown because we had many futures holding the connection and never releasing it, resulting in new futures timing out while trying to get the connection. After acquiring the client, the system would wait for the global rate limits service to perform work, and during this wait, the connection remained held.
  • It scales the number of active connections based on the maximum concurrency.

Related to: https://github.com/getsentry/team-ingest/issues/673

#skip-changelog

@iambriccardo iambriccardo changed the title Fix fix(processor): Fix client handling and number of active connections Mar 20, 2025
@iambriccardo iambriccardo requested a review from Dav1dde March 20, 2025 15:08
@iambriccardo iambriccardo marked this pull request as ready for review March 20, 2025 15:08
@iambriccardo iambriccardo requested a review from a team as a code owner March 20, 2025 15:08
@iambriccardo iambriccardo merged commit 2211a7b into master Mar 21, 2025
34 checks passed
@iambriccardo iambriccardo deleted the riccardo/fix/locked-system branch March 21, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants