Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spans): extract transaction breakdowns into measurements #4600

Merged
merged 5 commits into from
Mar 21, 2025

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Mar 20, 2025

closes #4598

More details found in the issue above. This PR extracts transaction breakdowns into measurements, so that they are automatically stored in the eap dataset. (Snuba does not look at breakdowns at all, but it automatically stores all measurements) We are moving the insights overview pages to eap, and the product relies on these breakdown values.

@DominikB2014 DominikB2014 requested a review from a team as a code owner March 20, 2025 18:26
Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, are we eventually planning to send measurements directly from the SDK instead of building them from breakdowns?

@DominikB2014
Copy link
Contributor Author

are we eventually planning to send measurements directly from the SDK instead of building them from breakdowns
@iambriccardo Good question! I'm planning to to sync with the SDK team about that one, but i think that's what we should do eventually. Regardless, we'll likely have to keep this code for sometime to provide backwards compatibility

@iambriccardo
Copy link
Member

are we eventually planning to send measurements directly from the SDK instead of building them from breakdowns

@iambriccardo Good question! I'm planning to to sync with the SDK team about that one, but i think that's what we should do eventually. Regardless, we'll likely have to keep this code for sometime to provide backwards compatibility

Thanks for the clarification! Keeping it for backwards compatibility sounds good to me.

@DominikB2014 DominikB2014 merged commit e40a841 into master Mar 21, 2025
25 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/extract-breakdowns branch March 21, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract transaction breakdowns into measurements
2 participants