WIP: task profiling #3396
Draft
WIP: task profiling #3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- task profiling ([#3396](https://github.com/getsentry/sentry-dotnet/pull/3396))If none of the above apply, you can opt out of this check by adding |
This was referenced Jan 22, 2025
This was referenced Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the profiler to track tasks across threadpools. It makes use of ActivityComputer, which is currently only patched in our fork and not upstream.
Also, there's currently a blocking issue because with a recent change in TraceLog to clean data structures after a sample is processed (see #3375 (comment)). The problem is that the ActivityComputer relies on reading older stacks when figuring out creator stacktraces (AFAICT). We'd need to find solution for that to make the ActivityComputer work with realtime sessions, while not reverting the indefinitely growing data structures.
Maybe, we could make ActivityComputer process and keep the needed stack trace information at the time that sample occurs, if that is possible?
In any case, I'd wait until the perfview PR with the main changes we need is merged, before opening another set of changes.